forked from MITGameLab/OpenRelativity
-
Notifications
You must be signed in to change notification settings - Fork 2
WIP: Collision debugging #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Gravity waves" went away! This is probably a good thing! The waves I'm hypothesizing in Schwarzschild are probably "thermal," but, at least, that code is optional. The point here is still to reduce "code debt," first, and it seems to be improving the physics. This major qualitative change arose in trying to isolate why collisions seemed so observer dependent. They are much less so, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old collision code was semi- ad hoc and not "rocket science" quality. It would be great if we could transform the inputs passed into the physics update loop to get PhysX to return results that we could transform back into relativistic collision outputs.
In the limit of low relativistic effects, "straight" PhysX is already a reasonable approximation to what we want. Literature exists on relativistic collision, but the most readily available and visible resources tend to develop relativistic collision in terms of "scattering angle" parameters. Really, what we want is relativistic impulse mechanics, which does not seem to be as well covered. Based on previous work, my guess is, "impulse" relates collision rapidities. (https://en.wikipedia.org/wiki/Rapidity)
At an idealized point of contact, distance between rigid bodies (at the contact point) is 0, and simultaneity can be established. Much has been said about how rigid body mechanics are a specifically bad or conceptually inadmissible model for relativistic collision. We don't seek to "rewrite the book" on this topic, we just want to do the best we can within Unity's inbuilt physics system.